Attention is currently required from: fixeria, laforge, neels. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/42120?usp=email )
Change subject: cp_peer: Implement local originated heartbeat procedure ...................................................................... Patch Set 1: (1 comment) File src/libosmo-pfcp/pfcp_cp_peer.c: https://gerrit.osmocom.org/c/libosmo-pfcp/+/42120/comment/86dd2496_18114569?usp=email : PS1, Line 112: unsigned int tval_rx_heartbeat_s = : osmo_tdef_get(cp_peer->ep->cfg.tdefs, OSMO_PFCP_TIMER_HEARTBEAT_RESP, OSMO_TDEF_S, -1); : o > I understand that the user can configure the HB interval and response timeout > separately - this is f […] Yes, because you are expected to set "HB response timeout" to be > "HB interval". The tval_rx_heartbeat_s is expected to be set so that it waits up to N Heartbeat Requests lost/non-answered when it triggers. So usually you'd set eg. tval_tx_heartbeat_s=3, tval_rx_heartbeat_s=10 to trigger after 3 hearbeat request went unanswered. Unfortunately the PFCP spec doesn't really provide detailed information on how the Heartbeat procedure is supposed to figure out assoc timeout, so we are basically doing something similar to what is done iirc in GTP here. What I realize now is that the values set by default in the tdef are both 15s for both tval_tx_heartbeat_s and tval_rx_heartbeat_s, which may be too tight. I'll update tval_rx_heartbeat_s to 25 or so. This values were not used so far since this feature was not implemented, and value "15s" doesn't really show up in the spec in any way afaict. -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/42120?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I7efc0961e1ea39dd7f4cc6ba96be4cf5ce9a2d6c Gerrit-Change-Number: 42120 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Mon, 16 Feb 2026 10:50:47 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Comment-In-Reply-To: pespin <[email protected]>
