Attention is currently required from: laforge, neels, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/42120?usp=email )
Change subject: cp_peer: Implement local originated heartbeat procedure ...................................................................... Patch Set 1: (1 comment) File src/libosmo-pfcp/pfcp_cp_peer.c: https://gerrit.osmocom.org/c/libosmo-pfcp/+/42120/comment/bea3416e_9b85baad?usp=email : PS1, Line 112: unsigned int tval_rx_heartbeat_s = : osmo_tdef_get(cp_peer->ep->cfg.tdefs, OSMO_PFCP_TIMER_HEARTBEAT_RESP, OSMO_TDEF_S, -1); : o > Yes, because you are expected to set "HB response timeout" to be > "HB > interval". Where this expectation is coming from? Is this stated in the specs. somewhere? Anyway, I still see a problem here: * `tval_tx_heartbeat_s` (HB interval) = 10s * `tval_rx_heartbeat_s` (HB response timeout) = 15s Scenario: * [0.0s] Tx HEARTBEAT Req (initial) * re-schedule `heartbeat_tx_timer` (+10s, triggers @ 10.0s) * re-schedule `heartbeat_rx_timer` (+12s, triggers @ 12.0s) * [0.5s] Rx HEARTBEAT Rsp * re-schedule `heartbeat_rx_timer` (+12s, triggers @ 12.5s) * [10.0s] Tx HEARTBEAT Req * re-schedule `heartbeat_tx_timer` (+10s, triggers @ 20.0s) * [12.5s] `heartbeat_rx_timer` expires, `PFCP_CP_PEER_EV_HEARTBEAT_TIMEOUT` * [13.0s] Rx HEARTBEAT Rsp (late?) Even though the 2nd `HEARTBEAT Rsp` was received only 3.0s after the 2nd `HEARTBEAT Req` (less than the timeout of 15.0s), the timeout condition was already declared. This is why I believe the `heartbeat_rx_timer` needs to be re-scheduled when sending the `HEARTBEAT Req`. -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/42120?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I7efc0961e1ea39dd7f4cc6ba96be4cf5ce9a2d6c Gerrit-Change-Number: 42120 Gerrit-PatchSet: 1 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Mon, 16 Feb 2026 11:18:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: fixeria <[email protected]>
