Attention is currently required from: fixeria, laforge, neels. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/libosmo-pfcp/+/42120?usp=email )
Change subject: cp_peer: Implement local originated heartbeat procedure ...................................................................... Patch Set 2: (1 comment) File src/libosmo-pfcp/pfcp_cp_peer.c: https://gerrit.osmocom.org/c/libosmo-pfcp/+/42120/comment/68d81be7_635a7a43?usp=email : PS1, Line 112: unsigned int tval_rx_heartbeat_s = : osmo_tdef_get(cp_peer->ep->cfg.tdefs, OSMO_PFCP_TIMER_HEARTBEAT_RESP, OSMO_TDEF_S, -1); : o > Where this expectation is coming from? Is this stated in the specs. somewhere? As mentioned, unfortunately the PFCP spec doesn't provide with detailed information on how the hearbeat procedure is expected to work. I simply took the existing timers in the code base and implemented it. > Even though the 2nd HEARTBEAT Rsp was received only 3.0s after the 2nd > HEARTBEAT Req (less than the timeout of 15.0s), Because that's not what the timeout is expected to express. The timeout doesn't express "how much time should it take to receive a response for a given Req", but simply "How much time without receiving a Heartbeat Response is acceptable", which is totally decoupled from the config of "how frequently to transmit Heartbeat Request" (but of course there's a relation to that). This is iirc how IT (Tias and Tiar) work in SCCP for instance, see eg. https://osmocom.org/issues/4343 -- To view, visit https://gerrit.osmocom.org/c/libosmo-pfcp/+/42120?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: libosmo-pfcp Gerrit-Branch: master Gerrit-Change-Id: I7efc0961e1ea39dd7f4cc6ba96be4cf5ce9a2d6c Gerrit-Change-Number: 42120 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-CC: fixeria <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: fixeria <[email protected]> Gerrit-Comment-Date: Mon, 16 Feb 2026 11:27:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Comment-In-Reply-To: pespin <[email protected]>
