Patch Set 1: Code-Review-1 (1 comment)
https://gerrit.osmocom.org/#/c/7572/1//COMMIT_MSG Commit Message: Line 19: err = eeprom_write( EEPROM_CFG_START_ADDR + ((int)&ee.cfg.v1.sysInfo - (int)&ee) I don't think it's good idea to indicate how exactly particular strings were changed - this could be seen by `git show / diff`. Please better explain why did you change from (type *) to (type), i.e. why does it make sense. -- To view, visit https://gerrit.osmocom.org/7572 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa7318387ad7bb248c261b1f428019244039e7d2 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Keith Whyte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-HasComments: Yes
