Patch Set 1: (2 comments)
https://gerrit.osmocom.org/#/c/7572/1//COMMIT_MSG Commit Message: Line 19: err = eeprom_write( EEPROM_CFG_START_ADDR + ((int)&ee.cfg.v1.sysInfo - (int)&ee) > I don't think it's good idea to indicate how Sure, I guess this was never intended as the final commit message to be merged. I don't /know/ why it makes sense, because I'm not a C programmer, but I'm told it should be pretty clear to anyone who is, and me, well, I'm not in the habit of explaining what I don't understand. One thing for sure, it was totally broken before this and works after. - I should have mentioned maybe the ticket where I demonstrate this in the commit? https://osmocom.org/issues/3121 https://gerrit.osmocom.org/#/c/7572/1/src/osmo-bts-sysmo/eeprom.c File src/osmo-bts-sysmo/eeprom.c: Line 498: err = eeprom_read( EEPROM_CFG_START_ADDR + ((int)&ee.cfg.v1.sysInfo - (int)&ee), sizeof(ee.cfg.v1.sysInfo), (char *)&ee.cfg.v1.sysInfo ); > I fail to see how this change can make it work, as afaik the sysmobts is a The only difference? What about that '*', It appears to be key. -- To view, visit https://gerrit.osmocom.org/7572 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa7318387ad7bb248c261b1f428019244039e7d2 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Keith Whyte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Keith Whyte <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-HasComments: Yes
