Patch Set 1: (1 comment)
https://gerrit.osmocom.org/#/c/7572/1/src/osmo-bts-sysmo/eeprom.c File src/osmo-bts-sysmo/eeprom.c: Line 498: err = eeprom_read( EEPROM_CFG_START_ADDR + ((int)&ee.cfg.v1.sysInfo - (int)&ee), sizeof(ee.cfg.v1.sysInfo), (char *)&ee.cfg.v1.sysInfo ); > I fail to see how this change can make it work, as afaik the sysmobts is a OK, I verified that this is the case by calling eeprom_read() twice in the code, 1st with the (uint32_t*) and 2nd with (int) Pre this patch the value passed as addr (which is int by the way) to eeprom_read() is wrong, after the patch it is correct: <0006> eeprom.c:665 First time. <0006> eeprom.c:1700 Address Passed to eeprom_read(): 265. <0006> eeprom.c:667 Second time. <0006> eeprom.c:1700 Address Passed to eeprom_read(): 292. I didn't use this call obviously, but the one in eeprom_ReadRfClockCal() -- To view, visit https://gerrit.osmocom.org/7572 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iaa7318387ad7bb248c261b1f428019244039e7d2 Gerrit-PatchSet: 1 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Keith Whyte <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Keith Whyte <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-HasComments: Yes
