Patch Set 2:
> As I saig, we probably want to cast to (uint8_t*)
Right, probably... except not, because I already tried uint8_t before I pushed
the first patch set, and the compiler warned:
eeprom.c:663:57: warning: cast from pointer to integer of different size
[-Wpointer-to-int-cast]
err = eeprom_read( EEPROM_CFG_START_ADDR +
((uint8_t)&ee.cfg.v1.rfClk - (uint8_t)&ee), sizeof(ee.cfg.v1.rfClk), (char
*)&ee.cfg.v1.rfClk );
In fact, the only type that doesn't warn for me if the state of the code before
the patch that broke this, that is to say. uint32_t. So it's compiler of system
dependent.
--
To view, visit https://gerrit.osmocom.org/7572
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaa7318387ad7bb248c261b1f428019244039e7d2
Gerrit-PatchSet: 2
Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Owner: Keith Whyte <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: Keith Whyte <[email protected]>
Gerrit-Reviewer: Pau Espin Pedrol <[email protected]>
Gerrit-Reviewer: Vadim Yanitskiy <[email protected]>
Gerrit-HasComments: No
