Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11929 )
Change subject: ctrl: add function to skip TRAP messages ...................................................................... Patch Set 2: Code-Review-1 (3 comments) https://gerrit.osmocom.org/#/c/11929/2/osmopy/osmo_ipa.py File osmopy/osmo_ipa.py: https://gerrit.osmocom.org/#/c/11929/2/osmopy/osmo_ipa.py@121 PS2, Line 121: if data == None or len(data) == 0: That's not needed anymore thanks to your other commits previous to this one. https://gerrit.osmocom.org/#/c/11929/2/osmopy/osmo_ipa.py@126 PS2, Line 126: if (int(length) != 0): What if you have an empty IPA header followed by the packet you want? you are loosing it here by returning None at the end of the function. Instead you should go the recursive self.skip_traps(tail) path if int(length)==0. https://gerrit.osmocom.org/#/c/11929/2/osmopy/osmo_ipa.py@128 PS2, Line 128: return self.skip_traps(tail) Ah I see you need the code I commented above as a base case. IMHO it be easier to do it in a loop, no need to go recursive way here, but fine. -- To view, visit https://gerrit.osmocom.org/11929 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51ce207c19a1ca96c3e2af7d5efd64f79b02fbb4 Gerrit-Change-Number: 11929 Gerrit-PatchSet: 2 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: daniel <[email protected]> Gerrit-Comment-Date: Mon, 26 Nov 2018 18:14:58 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
