Max has posted comments on this change. ( https://gerrit.osmocom.org/11929 )
Change subject: ctrl: add function to skip TRAP messages ...................................................................... Patch Set 2: (1 comment) Having said that, I'd very much welcome your patch which would add this (and couple of more) test cases with odd invalid input to make this more robust. https://gerrit.osmocom.org/#/c/11929/2/osmopy/osmo_ipa.py File osmopy/osmo_ipa.py: https://gerrit.osmocom.org/#/c/11929/2/osmopy/osmo_ipa.py@126 PS2, Line 126: if (int(length) != 0): > Sorry I meant an empty IPA payload. […] That's only possible if you specifically craft such message using some non-osmocom tool. Which certainly is possible but there're dozens of places where we don't check for that. Making this tolerant to malicious input would be nice but is definitely outside of the scope for this patch. In case of osmocom routines length = len(payload) + 1 and payload is always non-empty string of at least 6 bytes. -- To view, visit https://gerrit.osmocom.org/11929 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51ce207c19a1ca96c3e2af7d5efd64f79b02fbb4 Gerrit-Change-Number: 11929 Gerrit-PatchSet: 2 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: daniel <[email protected]> Gerrit-Comment-Date: Mon, 26 Nov 2018 18:50:27 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
