Max has posted comments on this change. ( https://gerrit.osmocom.org/11929 )
Change subject: ctrl: add function to skip TRAP messages ...................................................................... Patch Set 2: (1 comment) Please elaborate - either complete function as you'd like to see it or test-case which you think current version would fail. I have hard time wrapping my head around this. https://gerrit.osmocom.org/#/c/11929/2/osmopy/osmo_ipa.py File osmopy/osmo_ipa.py: https://gerrit.osmocom.org/#/c/11929/2/osmopy/osmo_ipa.py@126 PS2, Line 126: if (int(length) != 0): > if length == 0 or payload... Either I'm not following or this doesn't make sense. What's the point of go into recursion on 2nd message if the length of the 1st one already indicates that we should return None? -- To view, visit https://gerrit.osmocom.org/11929 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51ce207c19a1ca96c3e2af7d5efd64f79b02fbb4 Gerrit-Change-Number: 11929 Gerrit-PatchSet: 2 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: daniel <[email protected]> Gerrit-Comment-Date: Tue, 27 Nov 2018 11:00:31 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
