Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/11929 )
Change subject: ctrl: add function to skip TRAP messages ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/11929/2/osmopy/osmo_ipa.py File osmopy/osmo_ipa.py: https://gerrit.osmocom.org/#/c/11929/2/osmopy/osmo_ipa.py@126 PS2, Line 126: if (int(length) != 0): > That's only possible if you specifically craft such message using some > non-osmocom tool. […] BTW, the () and the int() doesn't seem to be needed here (length is used as an integer in line 127). And regarding this check, I'm not asking you to refactor a big code, it's simply a matter of doing: if length == 0 or payload[:(length + 3)].decode('utf-8').startswith(self.CTRL_TRAP): return self.skip_traps(tail) -- To view, visit https://gerrit.osmocom.org/11929 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: python/osmo-python-tests Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51ce207c19a1ca96c3e2af7d5efd64f79b02fbb4 Gerrit-Change-Number: 11929 Gerrit-PatchSet: 2 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: daniel <[email protected]> Gerrit-Comment-Date: Mon, 26 Nov 2018 18:56:19 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
