osmith has posted comments on this change. ( https://gerrit.osmocom.org/12046 )
Change subject: contrib/jenkins.sh: build and publish manuals ...................................................................... Patch Set 2: > I see two separate issues and would prefer these to be solved first: Oh, too bad I saw the comment only after posting the patches to the other repos... :\ I'm sorry for all the e-mail noise this has caused. > The scripts should work with "set -u" I can do the change, but I'm wondering for the reasons - as I understand, we are not using "set -u" with these scripts, right? Why make them work with it in theory then? > Positionable arguments are a slippery hill (ask about iptables). Okay, understandable. Well then I'll go change the scripts to use getopt. -- To view, visit https://gerrit.osmocom.org/12046 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id460a932431b46b88937d96637edd209ca56db97 Gerrit-Change-Number: 12046 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: Holger Freyther <[email protected]> Gerrit-Comment-Date: Mon, 03 Dec 2018 10:56:29 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
