Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12046 )
Change subject: contrib/jenkins.sh: build and publish manuals ...................................................................... Patch Set 2: Code-Review+1 (1 comment) https://gerrit.osmocom.org/#/c/12046/2/contrib/jenkins.sh File contrib/jenkins.sh: https://gerrit.osmocom.org/#/c/12046/2/contrib/jenkins.sh@74 PS2, Line 74: if [ "$WITH_MANUALS" = "True" ]; then I think the permutations of --publish and WITH_MANUALS need to be explained somewhere. Maybe in a comment on top? (Also thinking, maybe also use an env var instead of --publish, a bit weird to use two different ways to pass options for the same kind-of-thing) -- To view, visit https://gerrit.osmocom.org/12046 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id460a932431b46b88937d96637edd209ca56db97 Gerrit-Change-Number: 12046 Gerrit-PatchSet: 2 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: Holger Freyther <[email protected]> Gerrit-Comment-Date: Mon, 03 Dec 2018 13:10:10 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
