Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12046 )
Change subject: contrib/jenkins.sh: build and publish manuals ...................................................................... Patch Set 3: I'm sorry to say I also dislike this --publish parameter, and I'd prefer having a PUBLISH_MANUALS="1" envar (other values mean don't publish). No need to use a parameter and care of later problems where we can use envvars and be done with it. And this way we don't use different methods to pass same kind of information. It's even possible that we can pass this envvar PUBLISH_MANUALS=1 as a job configuration option in osmo-ci instead of writing it in the cmd line of each job in master-builds.yml in osmo-ci. -- To view, visit https://gerrit.osmocom.org/12046 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Id460a932431b46b88937d96637edd209ca56db97 Gerrit-Change-Number: 12046 Gerrit-PatchSet: 3 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: Holger Freyther <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Mon, 03 Dec 2018 19:00:52 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
