osmith has posted comments on this change. ( https://gerrit.osmocom.org/12046 )
Change subject: contrib/jenkins.sh: build and publish manuals
......................................................................
Patch Set 2:
After a longer chat discussion:
* I looked into getopt/getopts parsing, and whether it would be really worth
the overhead. Neels and I both argued that it's unlikely that other commandline
options will appear in the future, so we were against any argument parsing
method. Holger said: "fair enough. I just wanted to point out that the approach
is fragile and not scalable. We can re-evaluate the next time somebody is
adding an option to the scripts."
* Regarding set -u ("$publish" = "--publish" vs. "y$publish" = "y--publish"),
since we don't use either set +u or #!/bin/sh -u in this script, this would not
make any difference.
* Neels suggested to explain all incoming parameters (environment and the only
commandline parameter, --publish) on top of each of the jenkins.sh scripts I'm
modifying. I'm working on that now.
Thanks everybody for reviewing, highly appreciated!
--
To view, visit https://gerrit.osmocom.org/12046
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Id460a932431b46b88937d96637edd209ca56db97
Gerrit-Change-Number: 12046
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-CC: Holger Freyther <[email protected]>
Gerrit-Comment-Date: Mon, 03 Dec 2018 13:38:22 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
