Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12357 )
Change subject: mgcp_client: make domain part of endpoint configurable ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12357/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/12357/1//COMMIT_MSG@37 PS1, Line 37: domain bsc > Does this have to match the "mgw endpoint-domain" value in osmo-bsc. […] of course. The server already allows changing the expected domain name, but the client does not until this patch gets merged. This patch does not affect the server side, only the client. The default expected one is 'mgw', but you can set '*' to accept any (which was added for SCCPlite, where the MSC tested actually sent an IP address) DEFUN(cfg_mgcp_domain, cfg_mgcp_domain_cmd, "domain NAME", "Set the domain part expected in MGCP messages' endpoint names\n" "Qualified domain name expected in MGCP endpoint names, or '*' to accept any domain\n") What happens if they differ: osmo-mgw rejects the CRCX. It's all up to your .cfg files. Actually, to do it really right, the goal would be to have that domain name match the actual server domain name and/or any IP addresses it listens on. This patch is mere cosmetics to improve the context and help analyse RTP streams. In the long run, we might place the 'mgw remote-addr' in there as endpoint-domain by default, and setting this endpoint-domain could manually override that; osmo-mgw could accept all with '*' or compare to the interface the MGCP was received on / have a list of accepted domains... But there isn't really a benefit to that, so I doubt that we will need that ever, really. -- To view, visit https://gerrit.osmocom.org/12357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia662016f29dd8727d9c4626d726729641e21e1f8 Gerrit-Change-Number: 12357 Gerrit-PatchSet: 1 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Comment-Date: Wed, 19 Dec 2018 17:13:23 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
