Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/12357 )
Change subject: mgcp_client: make domain part of endpoint configurable ...................................................................... Patch Set 3: (2 comments) https://gerrit.osmocom.org/#/c/12357/3//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/12357/3//COMMIT_MSG@20 PS3, Line 20: Rationale: reading pcaps becomes so much easier when each of osmo-bsc and : osmo-msc address their MGW with differing domain names. Otherwise, both will : have a '0@mgw' endpoint and it gets really confusing. How cold both use the same endpoint? The endpoint names (local part in front of @) is allocated by the mgw, so if osmo-bsc uses 0@mgw, osmo-msc will get allocated foo@mgw where foo != "0". https://gerrit.osmocom.org/#/c/12357/3/include/osmocom/mgcp_client/mgcp_client.h File include/osmocom/mgcp_client/mgcp_client.h: https://gerrit.osmocom.org/#/c/12357/3/include/osmocom/mgcp_client/mgcp_client.h@28 PS3, Line 28: 64 why 64? Is there some kind of maximum DNS domain name length we should use? -- To view, visit https://gerrit.osmocom.org/12357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia662016f29dd8727d9c4626d726729641e21e1f8 Gerrit-Change-Number: 12357 Gerrit-PatchSet: 3 Gerrit-Owner: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-CC: Stefan Sperling <[email protected]> Gerrit-CC: Vadim Yanitskiy <[email protected]> Gerrit-Comment-Date: Sat, 22 Dec 2018 20:23:53 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
