Vadim Yanitskiy has posted comments on this change. ( 
https://gerrit.osmocom.org/12357 )

Change subject: mgcp_client: make domain part of endpoint configurable
......................................................................


Patch Set 3:

(2 comments)

https://gerrit.osmocom.org/#/c/12357/3/src/libosmo-mgcp-client/mgcp_client.c
File src/libosmo-mgcp-client/mgcp_client.c:

https://gerrit.osmocom.org/#/c/12357/3/src/libosmo-mgcp-client/mgcp_client.c@822
PS3, Line 822: name[0]?
Missing space.


https://gerrit.osmocom.org/#/c/12357/3/src/libosmo-mgcp-client/mgcp_client.c@830
PS3, Line 830: "rtpbridge/*@%s"
Oh, wow, this breaks Gerrit's syntax highlighting :D



--
To view, visit https://gerrit.osmocom.org/12357
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia662016f29dd8727d9c4626d726729641e21e1f8
Gerrit-Change-Number: 12357
Gerrit-PatchSet: 3
Gerrit-Owner: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <[email protected]>
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-CC: Vadim Yanitskiy <[email protected]>
Gerrit-Comment-Date: Thu, 20 Dec 2018 00:41:38 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No

Reply via email to