Stefan Sperling has posted comments on this change. ( https://gerrit.osmocom.org/12357 )
Change subject: mgcp_client: make domain part of endpoint configurable ...................................................................... Patch Set 3: (2 comments) https://gerrit.osmocom.org/#/c/12357/3/src/libosmo-mgcp-client/mgcp_client.c File src/libosmo-mgcp-client/mgcp_client.c: https://gerrit.osmocom.org/#/c/12357/3/src/libosmo-mgcp-client/mgcp_client.c@709 PS3, Line 709: sizeof(mgcp->actual.endpoint_domain_name)); Check for truncation and log a warning if name is truncated? Or perhaps even error out because truncation of multiple names risks duplicates? if (strlcpy(pname, dir, sizeof(pname)) >= sizeof(pname)) goto toolong; http://man.openbsd.org/strlcpy#EXAMPLES https://gerrit.osmocom.org/#/c/12357/3/src/libosmo-mgcp-client/mgcp_client_vty.c File src/libosmo-mgcp-client/mgcp_client_vty.c: https://gerrit.osmocom.org/#/c/12357/3/src/libosmo-mgcp-client/mgcp_client_vty.c@147 PS3, Line 147: sizeof(global_mgcp_client_conf->endpoint_domain_name)); Truncation check? -- To view, visit https://gerrit.osmocom.org/12357 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia662016f29dd8727d9c4626d726729641e21e1f8 Gerrit-Change-Number: 12357 Gerrit-PatchSet: 3 Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-CC: Stefan Sperling <s...@stsp.name> Gerrit-CC: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Comment-Date: Thu, 20 Dec 2018 17:16:25 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
