Neels Hofmeyr has posted comments on this change. ( https://gerrit.osmocom.org/12571 )
Change subject: VLR: use msgb_eq_data_print() for comparison ...................................................................... Patch Set 1: Code-Review-1 (4 comments) https://gerrit.osmocom.org/#/c/12571/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/12571/1//COMMIT_MSG@9 PS1, Line 9: This simplifies tests refactoring by showing exact byte where mismatch that's good. What I don't like is that msgb_eq_data_print() logs a multiline string to the osmo logging -- that's technically not allowed. I thought I had placed that review before merging. https://gerrit.osmocom.org/#/c/12571/1//COMMIT_MSG@10 PS1, Line 10: happened. It also makes code more readable. That's a personal preference at best. https://gerrit.osmocom.org/#/c/12571/1/tests/msc_vlr/msc_vlr_tests.c File tests/msc_vlr/msc_vlr_tests.c: https://gerrit.osmocom.org/#/c/12571/1/tests/msc_vlr/msc_vlr_tests.c@573 PS1, Line 573: uint8_t buf[OSMO_GSUP_MAX_MSISDN_LEN * OSMO_GSUP_MAX_CALLED_PARTY_BCD_LEN]; completely unrelated constants. Just use 4096 or 1024... https://gerrit.osmocom.org/#/c/12571/1/tests/msc_vlr/msc_vlr_tests.c@579 PS1, Line 579: OSMO_ASSERT(gsup_tx_expected); OSMO_ASSERT(strlen(gsup_tx_expected) <= (sizeof(buf) * 2)); -- To view, visit https://gerrit.osmocom.org/12571 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9771c973f2bc55580f4c146bdbeeb1609d56786 Gerrit-Change-Number: 12571 Gerrit-PatchSet: 1 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Wed, 16 Jan 2019 13:09:38 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
