Max has posted comments on this change. ( https://gerrit.osmocom.org/12571 )
Change subject: VLR: use msgb_eq_data_print() for comparison ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/12571/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/12571/1//COMMIT_MSG@9 PS1, Line 9: This simplifies tests refactoring by showing exact byte where mismatch > that's technically not allowed Ok, a little clarification: it is technically allowed. We probably shouldn't do multiline logging in regular programs/libraries for aesthetic reasons but it's perfectly fine in unit-tests - there're no technical reasons to avoid it. Especially in this case where log output will be seen only if test fails. https://gerrit.osmocom.org/#/c/12571/1//COMMIT_MSG@10 PS1, Line 10: happened. It also makes code more readable. > That's a personal preference at best. Yes? You can see the person's name in "Author" header of the commit log. Having said that, do you really find multi-line if() clause more readable? -- To view, visit https://gerrit.osmocom.org/12571 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9771c973f2bc55580f4c146bdbeeb1609d56786 Gerrit-Change-Number: 12571 Gerrit-PatchSet: 2 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Thu, 17 Jan 2019 14:48:04 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
