osmith has posted comments on this change. ( https://gerrit.osmocom.org/12571 )
Change subject: VLR: use msgb_eq_data_print() for comparison
......................................................................
Patch Set 2: Code-Review+1
Change looks good to me.
I find this useful, and I can't see how having a multiline string logged here
would be an issue. As Max said, it is only logged in case of error anyway. The
code does look cleaner to me in the new version.
Old output:
Mismatch! Expected:
14010809710000004026f0280102
New output:
DLGLOBAL __wrap_osmo_gsup_client_send() L0 data mismatch:
expected 14 01 08 09 71 00 00 00 40 26 f0 28 01 02
!!
msgb 04 01 08 09 71 00 00 00 40 26 f0 28 01 02
--
To view, visit https://gerrit.osmocom.org/12571
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-msc
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: If9771c973f2bc55580f4c146bdbeeb1609d56786
Gerrit-Change-Number: 12571
Gerrit-PatchSet: 2
Gerrit-Owner: Max <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Max <[email protected]>
Gerrit-Reviewer: Neels Hofmeyr <[email protected]>
Gerrit-Reviewer: Stefan Sperling <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Comment-Date: Thu, 24 Jan 2019 17:15:26 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: Yes
