Max has posted comments on this change. ( https://gerrit.osmocom.org/12571 )
Change subject: VLR: use msgb_eq_data_print() for comparison ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12571/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/12571/1//COMMIT_MSG@9 PS1, Line 9: This simplifies tests refactoring by showing exact byte where mismatch > logs a multiline string to the osmo logging -- that's technically not allowed. First time I hear about this. Why multiline logging is not allowed? I'm pretty sure I've seen it in several places before. -- To view, visit https://gerrit.osmocom.org/12571 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If9771c973f2bc55580f4c146bdbeeb1609d56786 Gerrit-Change-Number: 12571 Gerrit-PatchSet: 1 Gerrit-Owner: Max <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Stefan Sperling <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Wed, 16 Jan 2019 13:21:11 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
