Max has posted comments on this change. ( https://gerrit.osmocom.org/12682 )
Change subject: Support Emergency Calling ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12682/1/src/mncc.c File src/mncc.c: https://gerrit.osmocom.org/#/c/12682/1/src/mncc.c@427 PS1, Line 427: if (data->emergency) { > which part? I thin the if (data->emergency) is correct. […] Curious, why the goto necessary in a first place? We don't have to screen parameters in case of emergency? Which of the conditions below trigger call reject and why? -- To view, visit https://gerrit.osmocom.org/12682 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d0adb61dfa82e7ded5f41d9bc773d546112c9f1 Gerrit-Change-Number: 12682 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Whyte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Keith Whyte <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-CC: Max <[email protected]> Gerrit-Comment-Date: Wed, 23 Jan 2019 12:07:51 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
