Max has posted comments on this change. ( https://gerrit.osmocom.org/12682 )
Change subject: Support Emergency Calling ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/12682/1/src/mncc.c File src/mncc.c: https://gerrit.osmocom.org/#/c/12682/1/src/mncc.c@427 PS1, Line 427: if (data->emergency) { > data->called is invalid I don't get it: if data->called is invalid than how can you set a number inside of it? Also, no code between goto and cont_setup seems to access data->called so I don't understand which of the checks below fails and why? -- To view, visit https://gerrit.osmocom.org/12682 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5d0adb61dfa82e7ded5f41d9bc773d546112c9f1 Gerrit-Change-Number: 12682 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Whyte <ke...@rhizomatica.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Keith Whyte <ke...@rhizomatica.org> Gerrit-CC: Harald Welte <lafo...@gnumonks.org> Gerrit-CC: Max <msur...@sysmocom.de> Gerrit-Comment-Date: Thu, 24 Jan 2019 17:03:52 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
