osmith has posted comments on this change. ( https://gerrit.osmocom.org/12730 )
Change subject: Inactive connection cleanup (disabled by default) ...................................................................... Patch Set 1: (2 comments) Good point with LCLS! > I agree that there should be vty switch for that. Also I think it should be > off by default. Done. > Would be nice to clarify in commit message what prompted this feature in more > details besides ticket link. Done. https://gerrit.osmocom.org/#/c/12730/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/12730/1//COMMIT_MSG@12 PS1, Line 12: arrive. > elaborate why it makes sense only for MDCX: […] Done https://gerrit.osmocom.org/#/c/12730/1/include/osmocom/mgcp/mgcp_internal.h File include/osmocom/mgcp/mgcp_internal.h: https://gerrit.osmocom.org/#/c/12730/1/include/osmocom/mgcp/mgcp_internal.h@41 PS1, Line 41: #define MGCP_CONN_TIMEOUT 180 > MGCP_CONN_DEFAULT_TIMEOUT and make it configurable in VTY I've removed the variable, because it is disabled by default now. -- To view, visit https://gerrit.osmocom.org/12730 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I18886052e090466f73829133c24f011806cc1fe0 Gerrit-Change-Number: 12730 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Comment-Date: Thu, 31 Jan 2019 11:28:32 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No