Max has posted comments on this change. ( https://gerrit.osmocom.org/12730 )
Change subject: Inactive connection cleanup (disabled by default) ...................................................................... Patch Set 5: (1 comment) Looks good except for odd test change which does not result in any changes to output. Could you clarify why it's necessary? https://gerrit.osmocom.org/#/c/12730/5/tests/mgcp/mgcp_test.c File tests/mgcp/mgcp_test.c: https://gerrit.osmocom.org/#/c/12730/5/tests/mgcp/mgcp_test.c@981 PS5, Line 981: endp.cfg = &cfg; Why adding watchdog requires this change? And how was it working before? -- To view, visit https://gerrit.osmocom.org/12730 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I18886052e090466f73829133c24f011806cc1fe0 Gerrit-Change-Number: 12730 Gerrit-PatchSet: 5 Gerrit-Owner: osmith <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <[email protected]> Gerrit-Reviewer: Neels Hofmeyr <[email protected]> Gerrit-Reviewer: Vadim Yanitskiy <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Thu, 31 Jan 2019 15:31:49 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
