Max has posted comments on this change. ( https://gerrit.osmocom.org/12730 )
Change subject: Inactive connection cleanup (disabled by default) ...................................................................... Patch Set 4: Code-Review-1 (2 comments) I think we should permit only non-zero timeouts to avoid ambiguity. https://gerrit.osmocom.org/#/c/12730/4/src/libosmo-mgcp/mgcp_vty.c File src/libosmo-mgcp/mgcp_vty.c: https://gerrit.osmocom.org/#/c/12730/4/src/libosmo-mgcp/mgcp_vty.c@158 PS4, Line 158: if (g_cfg->conn_timeout) Here we treat 0 as "no timeout configured" indicator. https://gerrit.osmocom.org/#/c/12730/4/src/libosmo-mgcp/mgcp_vty.c@1336 PS4, Line 1336: "conn-timeout <0-65534>", Here we allow timeout 0 to be configured by user. -- To view, visit https://gerrit.osmocom.org/12730 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I18886052e090466f73829133c24f011806cc1fe0 Gerrit-Change-Number: 12730 Gerrit-PatchSet: 4 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Comment-Date: Thu, 31 Jan 2019 14:25:33 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
