osmith has posted comments on this change. ( https://gerrit.osmocom.org/12730 )
Change subject: Inactive connection cleanup (disabled by default) ...................................................................... Patch Set 5: (1 comment) https://gerrit.osmocom.org/#/c/12730/5/tests/mgcp/mgcp_test.c File tests/mgcp/mgcp_test.c: https://gerrit.osmocom.org/#/c/12730/5/tests/mgcp/mgcp_test.c@981 PS5, Line 981: endp.cfg = &cfg; > Why adding watchdog requires this change? And how was it working before? This is needed, because mgcp_conn_watchdog_kick() looks up the timeout value in: conn->endp->cfg->conn_timeout These tests used to have no cfg in endp, which means dereferencing a NULL pointer at this point. It was working before, because nothing called by this test had accessed endp->cfg. -- To view, visit https://gerrit.osmocom.org/12730 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I18886052e090466f73829133c24f011806cc1fe0 Gerrit-Change-Number: 12730 Gerrit-PatchSet: 5 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Comment-Date: Thu, 31 Jan 2019 15:37:16 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
