daniel has posted comments on this change. ( https://gerrit.osmocom.org/11992 )
Change subject: libmsc/gsm_09_11.c: implement guard timer for NCSS sessions ...................................................................... Patch Set 10: Code-Review-1 (3 comments) https://gerrit.osmocom.org/#/c/11992/10/src/libmsc/gsm_09_11.c File src/libmsc/gsm_09_11.c: https://gerrit.osmocom.org/#/c/11992/10/src/libmsc/gsm_09_11.c@153 PS10, Line 153: if (conn->network->ncss_guard_timeout > 0) { This seems like possible race condition if you disable the ncss_guard_timeout from VTY while USSD sessions are active. Existing timers will not be rescheduled. https://gerrit.osmocom.org/#/c/11992/10/src/libmsc/gsm_09_11.c@156 PS10, Line 156: } else if (osmo_timer_pending(&trans->ss.watchdog)) { osmo_timer_del(&trans->ss.watchdog); } https://gerrit.osmocom.org/#/c/11992/10/src/libmsc/gsm_09_11.c@279 PS10, Line 279: } My comment above may apply here and elsewere as well -- To view, visit https://gerrit.osmocom.org/11992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf4d87c45e90324764073e8230e0fb9cb96dd9cb Gerrit-Change-Number: 11992 Gerrit-PatchSet: 10 Gerrit-Owner: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-CC: Stefan Sperling <s...@stsp.name> Gerrit-Comment-Date: Thu, 07 Feb 2019 10:33:59 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
