Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/11992 )
Change subject: libmsc/gsm_09_11.c: implement guard timer for NCSS sessions ...................................................................... Patch Set 10: (2 comments) looks fine to me, except for two typo (ESME/EUSE) in the commit message, and inconsistent naming watchdog vs. guard timer. https://gerrit.osmocom.org/#/c/11992/10//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/11992/10//COMMIT_MSG@9 PS10, Line 9: ESME EUSE? https://gerrit.osmocom.org/#/c/11992/10/include/osmocom/msc/transaction.h File include/osmocom/msc/transaction.h: https://gerrit.osmocom.org/#/c/11992/10/include/osmocom/msc/transaction.h@89 PS10, Line 89: watchdog; in the CC sub-struct above we call it "timer_guard". I would appreciate if we could align here and refer to it as a guard timer, not as a watchdog. They both do the same thing, right? -- To view, visit https://gerrit.osmocom.org/11992 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icf4d87c45e90324764073e8230e0fb9cb96dd9cb Gerrit-Change-Number: 11992 Gerrit-PatchSet: 10 Gerrit-Owner: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-CC: Stefan Sperling <s...@stsp.name> Gerrit-Comment-Date: Thu, 07 Feb 2019 10:21:45 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
