Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/12979 )
Change subject: Add option to GSM HR frames to RFC5593 representation ...................................................................... Patch Set 1: Code-Review-1 (6 comments) https://gerrit.osmocom.org/#/c/12979/1//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/12979/1//COMMIT_MSG@11 PS1, Line 11: contents byte to be prepended in front of the payload data along with Missing ) and capital C: (Table of Contents) https://gerrit.osmocom.org/#/c/12979/1//COMMIT_MSG@14 PS1, Line 14: The two formates can be distinguished easyly by their length. Then the typo: formats typo: easily https://gerrit.osmocom.org/#/c/12979/1/include/osmocom/mgcp/mgcp_internal.h File include/osmocom/mgcp/mgcp_internal.h: https://gerrit.osmocom.org/#/c/12979/1/include/osmocom/mgcp/mgcp_internal.h@131 PS1, Line 131: int rfc5993_hr_convert; we can use a bool here. https://gerrit.osmocom.org/#/c/12979/1/src/libosmo-mgcp/mgcp_network.c File src/libosmo-mgcp/mgcp_network.c: https://gerrit.osmocom.org/#/c/12979/1/src/libosmo-mgcp/mgcp_network.c@655 PS1, Line 655: /* This has been ported from openbsc.git, branch sylvain/32c3_codec, Is this comment really needed here? Better put it in commit description. https://gerrit.osmocom.org/#/c/12979/1/src/libosmo-mgcp/mgcp_network.c@701 PS1, Line 701: if (!rtp_end->rfc5993_hr_convert) makes more sense to move this conditional when calling this function, in forward_data(). https://gerrit.osmocom.org/#/c/12979/1/src/libosmo-mgcp/mgcp_vty.c File src/libosmo-mgcp/mgcp_vty.c: https://gerrit.osmocom.org/#/c/12979/1/src/libosmo-mgcp/mgcp_vty.c@733 PS1, Line 733: g_cfg->trunk.rfc5993_hr_convert = 1; bool here and later. -- To view, visit https://gerrit.osmocom.org/12979 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iceef19e5619f8c92dfa7c8cdecb2e9b15f0a11a1 Gerrit-Change-Number: 12979 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Wed, 20 Feb 2019 16:26:12 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: Yes
