tnt has posted comments on this change. ( https://gerrit.osmocom.org/12979 )
Change subject: Add option to GSM HR frames to RFC5593 representation ...................................................................... Patch Set 1: Code-Review-1 Confirmed by re-reading both rfc5993 (which refers to TS46.020, Annex B) and TS 101.318 5.2 Both use the exact same format for the actual 'speech data'. There is no bit shuffling or anything needed, the TOC header is the only difference. If you want a mode for that bit shuffling because you need to talk to some screwed up implementation, that should be a separate option 'enable_crappy_implementation_workaround' or something. -- To view, visit https://gerrit.osmocom.org/12979 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iceef19e5619f8c92dfa7c8cdecb2e9b15f0a11a1 Gerrit-Change-Number: 12979 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: tnt <[email protected]> Gerrit-Comment-Date: Wed, 20 Feb 2019 19:05:35 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes
