tnt has posted comments on this change. ( https://gerrit.osmocom.org/12979 )
Change subject: Add option to GSM HR frames to RFC5593 representation ...................................................................... Patch Set 1: > the sysmoBTS PHY (just like the PHY of the litecell 1.5 and the oc2g) > still have the bit ordering as you discovered it back then. But there is code to 'fix' that in osmo-bts itself osmo-bts-sysmo/tch.c And IMHO that's where it belongs. That weird format shouldn't appear on the wire ever. > It may be that the ETSI TS is using the same bit-ordering as the new RFC? In > that case it would really be a bug. Yes, both the ETSI TS spec and the new RFC have the same bit ordering. They both point to the same spec for the order of the parameter. Then one says "The first bit (b1) of the first parameter is placed in the most significant bit (MSB) (bit 0) of the first octet (octet 1) of the payload field;" and the other says "Within the GSM 06.20 codec parameter bits are numbered in big-endian manner." (i.e. MSB first), so both the same thing IMHO. (and really, the opposite makes no sense at all) > However, the additional 1-byte TOC definitely is a difference between the > ETSI HR RTP payload and the RFC5593. Yes indeed the only difference between the two formats is the TOC byte. -- To view, visit https://gerrit.osmocom.org/12979 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iceef19e5619f8c92dfa7c8cdecb2e9b15f0a11a1 Gerrit-Change-Number: 12979 Gerrit-PatchSet: 1 Gerrit-Owner: dexter <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Pau Espin Pedrol <[email protected]> Gerrit-Reviewer: tnt <[email protected]> Gerrit-CC: Harald Welte <[email protected]> Gerrit-Comment-Date: Wed, 20 Feb 2019 21:15:27 +0000 Gerrit-HasComments: No Gerrit-HasLabels: No
