tnt has posted comments on this change. ( https://gerrit.osmocom.org/12979 )

Change subject: Add option to GSM HR frames to RFC5593 representation
......................................................................


Patch Set 1:

I'm rechecking the specs right now, but this 'jumble' function was written to 
fix a _bug_ in an older sysmobts phy version. I'm pretty sure back then I 
checked both the RFC and IETF specs and both specified the same parameter bit 
order because the alternative is _nuts_ and it was just whoever implemented the 
phy misread the spec (because they are confusing, referencing different specs 
and some use b0 as msb and some as lsb ...)


--
To view, visit https://gerrit.osmocom.org/12979
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iceef19e5619f8c92dfa7c8cdecb2e9b15f0a11a1
Gerrit-Change-Number: 12979
Gerrit-PatchSet: 1
Gerrit-Owner: dexter <[email protected]>
Gerrit-Reviewer: Jenkins Builder (1000002)
Gerrit-Reviewer: Pau Espin Pedrol <[email protected]>
Gerrit-Reviewer: tnt <[email protected]>
Gerrit-Comment-Date: Wed, 20 Feb 2019 17:48:00 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No

Reply via email to