Harald Welte has posted comments on this change. ( https://gerrit.osmocom.org/13811 )
Change subject: Echo XID-Field of Type L3_PAR even when zero length ...................................................................... Patch Set 1: Code-Review-1 agreeing with Lynxis: the "echoing back" of the empty L3 XID must happen in SNDCP. Ideally, gprs_llc.c would not need any change -- To view, visit https://gerrit.osmocom.org/13811 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd75f7b943c84ed7264481fa2e4bc3cb2f6745d4 Gerrit-Change-Number: 13811 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Whyte <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Keith Whyte <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Comment-Date: Tue, 30 Apr 2019 05:55:25 +0000 Gerrit-HasComments: No Gerrit-HasLabels: Yes
