Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/13811 )
Change subject: Echo XID-Field of Type L3_PAR even when zero length ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13811/1/src/gprs/gprs_llc.c File src/gprs/gprs_llc.c: https://gerrit.osmocom.org/#/c/13811/1/src/gprs/gprs_llc.c@267 PS1, Line 267: xid_field_response = gprs_llc_dup_xid_field(lle->llme, xid_field); > If you "echo" something backs, it means you accept the XID. […] I understand that the "echo" is a confirmation. What I was referring to here is the need to call gprs_lls_cup_xid_field() but now I'm guessing that sndcp_sn_xid_ind() was "populating" the talloc_zero'd struct? or something like that? My lack of C and pointer foo strikes again... -- To view, visit https://gerrit.osmocom.org/13811 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd75f7b943c84ed7264481fa2e4bc3cb2f6745d4 Gerrit-Change-Number: 13811 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Whyte <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Keith Whyte <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Comment-Date: Tue, 30 Apr 2019 06:59:51 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
