Pau Espin Pedrol has posted comments on this change. ( https://gerrit.osmocom.org/13811 )
Change subject: Echo XID-Field of Type L3_PAR even when zero length ...................................................................... Patch Set 4: (2 comments) https://gerrit.osmocom.org/#/c/13811/4/src/gprs/gprs_sndcp.c File src/gprs/gprs_sndcp.c: https://gerrit.osmocom.org/#/c/13811/4/src/gprs/gprs_sndcp.c@1123 PS4, Line 1123: /* Some phones send zero byte length SNDCP frames */ Please append to this comment that we actually need to answer it in order to have them registered or whatever. https://gerrit.osmocom.org/#/c/13811/4/src/gprs/gprs_sndcp.c@1128 PS4, Line 1128: // xid_field_response = gprs_llc_dup_xid_field(lle->llme, xid_field_indication); These comments can be dropped. -- To view, visit https://gerrit.osmocom.org/13811 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd75f7b943c84ed7264481fa2e4bc3cb2f6745d4 Gerrit-Change-Number: 13811 Gerrit-PatchSet: 4 Gerrit-Owner: Keith Whyte <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Keith Whyte <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-CC: Pau Espin Pedrol <[email protected]> Gerrit-Comment-Date: Wed, 01 May 2019 11:13:46 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
