Keith Whyte has posted comments on this change. ( https://gerrit.osmocom.org/13811 )
Change subject: Echo XID-Field of Type L3_PAR even when zero length ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/13811/1/src/gprs/gprs_sndcp.c File src/gprs/gprs_sndcp.c: https://gerrit.osmocom.org/#/c/13811/1/src/gprs/gprs_sndcp.c@1122 PS1, Line 1122: > Better to do here an `if (xid_field_indication->data_len == 0) > gprs_llc_copy_xid()` and add a commen […] after 2 hours, I still cannot figure out what I would pass to gprs_llc_copy_xid() at this point. :(( -- To view, visit https://gerrit.osmocom.org/13811 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ibd75f7b943c84ed7264481fa2e4bc3cb2f6745d4 Gerrit-Change-Number: 13811 Gerrit-PatchSet: 1 Gerrit-Owner: Keith Whyte <[email protected]> Gerrit-Reviewer: Harald Welte <[email protected]> Gerrit-Reviewer: Jenkins Builder (1000002) Gerrit-Reviewer: Keith Whyte <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Comment-Date: Tue, 30 Apr 2019 09:14:13 +0000 Gerrit-HasComments: Yes Gerrit-HasLabels: No
