pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 )
Change subject: Add media mode parameter to sdp_create_file() ...................................................................... Patch Set 2: (2 comments) https://gerrit.osmocom.org/#/c/14993/1/src/sdp.c File src/sdp.c: https://gerrit.osmocom.org/#/c/14993/1/src/sdp.c@189 PS1, Line 189: } > no, no enum option missing, otherwise the compiler would warn. ^ That depends on compiler and version used (and flags used) :) https://gerrit.osmocom.org/#/c/14993/1/src/sdp.c@206 PS1, Line 206: mode_attribute ? mode_attribute : ""); > OK no problem.. […] If you consider having a more efficient and simplified code to be my personal style, I'm fine with that! -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ib4212d0174955042e7d80d3744ce632a4942ccb2 Gerrit-Change-Number: 14993 Gerrit-PatchSet: 2 Gerrit-Owner: keith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Tue, 30 Jul 2019 15:19:16 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <[email protected]> Comment-In-Reply-To: keith <[email protected]> Gerrit-MessageType: comment
