keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 )
Change subject: Add media mode parameter to sdp_create_file() ...................................................................... Patch Set 1: (1 comment) https://gerrit.osmocom.org/#/c/14993/1/src/sdp.c File src/sdp.c: https://gerrit.osmocom.org/#/c/14993/1/src/sdp.c@206 PS1, Line 206: mode_attribute ? mode_attribute : ""); > If you consider having a more efficient and simplified code to be my personal > style, I'm fine with t […] :-) OK.. I'm just kind of dumbstruck by the variety of coding and coding styles out there! It's hard to learn by example, when so much example is.er.. not so great. Happy to follow yours. Thanks! -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ib4212d0174955042e7d80d3744ce632a4942ccb2 Gerrit-Change-Number: 14993 Gerrit-PatchSet: 1 Gerrit-Owner: keith <ke...@rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <ke...@rhizomatica.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 30 Jul 2019 15:22:14 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Comment-In-Reply-To: keith <ke...@rhizomatica.org> Gerrit-MessageType: comment
