keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 )
Change subject: Add media mode parameter to sdp_create_file() ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/14993/2/src/sip.c File src/sip.c: https://gerrit.osmocom.org/#/c/14993/2/src/sip.c@389 PS2, Line 389: sdp = sdp_create_file(leg, other, sdp_sendrecv); > I also agree that a=sendrecv is implicit if absent. […] I feel it would be overkill to include https://tools.ietf.org/html/rfc3264#section-5.1 in the commit msg. -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ib4212d0174955042e7d80d3744ce632a4942ccb2 Gerrit-Change-Number: 14993 Gerrit-PatchSet: 2 Gerrit-Owner: keith <ke...@rhizomatica.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <ke...@rhizomatica.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: laforge <lafo...@gnumonks.org> Gerrit-CC: neels <nhofm...@sysmocom.de> Gerrit-Comment-Date: Thu, 01 Aug 2019 08:07:12 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: keith <ke...@rhizomatica.org> Comment-In-Reply-To: neels <nhofm...@sysmocom.de> Comment-In-Reply-To: laforge <lafo...@gnumonks.org> Gerrit-MessageType: comment
