keith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 )
Change subject: Add media mode parameter to sdp_create_file() ...................................................................... Patch Set 2: (4 comments) https://gerrit.osmocom.org/#/c/14993/2/src/sdp.c File src/sdp.c: https://gerrit.osmocom.org/#/c/14993/2/src/sdp.c@191 PS2, Line 191: mode_attribute = ""; > full ACK here to both comments. Done https://gerrit.osmocom.org/#/c/14993/2/src/sdp.c@191 PS2, Line 191: mode_attribute = ""; > (I'm not sure why, but at least by convention) end each case in 'break;' […] Done https://gerrit.osmocom.org/#/c/14993/2/src/sip.c File src/sip.c: https://gerrit.osmocom.org/#/c/14993/2/src/sip.c@389 PS2, Line 389: sdp = sdp_create_file(leg, other, sdp_sendrecv); > I also agree that a=sendrecv is implicit if absent. […] Done https://gerrit.osmocom.org/#/c/14993/2/src/sip.c@389 PS2, Line 389: sdp = sdp_create_file(leg, other, sdp_sendrecv); > before, this would send no "a=sendrecv", now it always does. […] Done -- To view, visit https://gerrit.osmocom.org/c/osmo-sip-connector/+/14993 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-sip-connector Gerrit-Branch: master Gerrit-Change-Id: Ib4212d0174955042e7d80d3744ce632a4942ccb2 Gerrit-Change-Number: 14993 Gerrit-PatchSet: 2 Gerrit-Owner: keith <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: keith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-CC: neels <[email protected]> Gerrit-Comment-Date: Thu, 01 Aug 2019 07:47:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: keith <[email protected]> Comment-In-Reply-To: neels <[email protected]> Comment-In-Reply-To: laforge <[email protected]> Gerrit-MessageType: comment
