laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15425 )
Change subject: Introduce osmo_tdef infra and timer VTY commands ...................................................................... Patch Set 2: (1 comment) https://gerrit.osmocom.org/#/c/15425/2//COMMIT_MSG Commit Message: https://gerrit.osmocom.org/#/c/15425/2//COMMIT_MSG@9 PS2, Line 9: even : overwriting whatever came from BTS I actually consider that rather problematic. There should be one point where a given timer is configured, and if that is in the BSC or the BTS (and then passed to the PCU), the PCU should just execute that and not allow for any override to it. This is confusing and can easily lead to inconsistencies. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15425 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I5cfb9ef01706124be262d4536617b9edb4601dd5 Gerrit-Change-Number: 15425 Gerrit-PatchSet: 2 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Fri, 06 Sep 2019 19:03:41 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
