pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15425 )
Change subject: Introduce osmo_tdef infra and timer VTY commands ...................................................................... Patch Set 3: (2 comments) https://gerrit.osmocom.org/#/c/15425/2/src/bts.cpp File src/bts.cpp: https://gerrit.osmocom.org/#/c/15425/2/src/bts.cpp@595 PS2, Line 595: -2002 > Looks odd to me, could you please add a comment? Why exactly -2002? Because I had to pick a number for the timer ;) We usually use XNNNN for our own timers. XNNNN transforms to negative timer numbers (to differentiate them from spec related TNNNN positive ones). It could be this timer was a spec-defined timer (and thus should be TNNNN and postive), but since it's not indicated in previous code it's difficult to say which one it is. If someone at some point finds the related timer, we can rename it. https://gerrit.osmocom.org/#/c/15425/2/src/tbf.cpp File src/tbf.cpp: https://gerrit.osmocom.org/#/c/15425/2/src/tbf.cpp@664 PS2, Line 664: enum tbf_timers t, > Do you think we still need this parameter? Most of the time I see: > T_START(tbf, TXXX, XXX, ... […] It is still needed unless we change implementation of how osmo_timer objects are stored, which for sure I'm not going to do now in the same patch. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15425 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I5cfb9ef01706124be262d4536617b9edb4601dd5 Gerrit-Change-Number: 15425 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-CC: laforge <[email protected]> Gerrit-Comment-Date: Mon, 09 Sep 2019 09:23:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <[email protected]> Gerrit-MessageType: comment
