pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15425 )
Change subject: Introduce osmo_tdef infra and timer VTY commands ...................................................................... Patch Set 5: (2 comments) https://gerrit.osmocom.org/#/c/15425/5/src/pcu_l1_if.cpp File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/#/c/15425/5/src/pcu_l1_if.cpp@515 PS5, Line 515: 33 > 3195? ugh good catch! https://gerrit.osmocom.org/#/c/15425/5/src/tbf_dl.cpp File src/tbf_dl.cpp: https://gerrit.osmocom.org/#/c/15425/5/src/tbf_dl.cpp@502 PS5, Line 502: -2001, > negative again? That's expected, it's how it's done for our own non-spec-related timers: struct osmo_tdef { /*! T1234 or X1234 number, corresponding to struct osmo_fsm_inst::T. * Positive values for T are considered to be 3GPP spec compliant and appear in logging and VTY as "T1234", * while negative values are considered to be Osmocom specific timers, represented in logging and VTY as * "X1234". Be aware that osmo_tdef_fsm_inst_state_chg() interprets T == 0 as "state without timeout". */ -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15425 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I5cfb9ef01706124be262d4536617b9edb4601dd5 Gerrit-Change-Number: 15425 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: lynxis lazus <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Comment-Date: Tue, 10 Sep 2019 14:19:33 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: lynxis lazus <[email protected]> Gerrit-MessageType: comment
