lynxis lazus has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/15425 )
Change subject: Introduce osmo_tdef infra and timer VTY commands ...................................................................... Patch Set 5: Code-Review-1 (3 comments) https://gerrit.osmocom.org/#/c/15425/5/src/pcu_l1_if.cpp File src/pcu_l1_if.cpp: https://gerrit.osmocom.org/#/c/15425/5/src/pcu_l1_if.cpp@515 PS5, Line 515: 33 3195? https://gerrit.osmocom.org/#/c/15425/5/src/tbf.cpp File src/tbf.cpp: https://gerrit.osmocom.org/#/c/15425/5/src/tbf.cpp@1344 PS5, Line 1344: -2000 -2000? https://gerrit.osmocom.org/#/c/15425/5/src/tbf_dl.cpp File src/tbf_dl.cpp: https://gerrit.osmocom.org/#/c/15425/5/src/tbf_dl.cpp@502 PS5, Line 502: -2001, negative again? -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/15425 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: master Gerrit-Change-Id: I5cfb9ef01706124be262d4536617b9edb4601dd5 Gerrit-Change-Number: 15425 Gerrit-PatchSet: 5 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <axilira...@gmail.com> Gerrit-Reviewer: laforge <lafo...@gnumonks.org> Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 10 Sep 2019 13:29:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment