neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16258 )
Change subject: D-GSM 3/n: implement roaming by mslookup in osmo-hlr ...................................................................... Patch Set 12: Code-Review-2 (2 comments) the handling of a remote hlr being up is ugly, because it is 1:1 plugged to the proxy code. At least for SMS over GSUP delivery in D-GSM, it would be required to take a different action when a remote HLR is resolved. So this should be a generalized cb into which the proxy code plugs. implementing now... https://gerrit.osmocom.org/c/osmo-hlr/+/16258/12/src/remote_hlr.c File src/remote_hlr.c: https://gerrit.osmocom.org/c/osmo-hlr/+/16258/12/src/remote_hlr.c@104 PS12, Line 104: static bool remote_hlr_up_yield(struct proxy *proxy, const struct proxy_subscr *proxy_subscr, void *data) this cb directly ties to the proxy implementation https://gerrit.osmocom.org/c/osmo-hlr/+/16258/12/src/remote_hlr.c@121 PS12, Line 121: proxy_subscrs_get_by_remote_hlr(g_hlr->gs->proxy, &remote_hlr->addr, remote_hlr_up_yield, remote_hlr); and here -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16258 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I2fe453553c90e6ee527ed13a13089900efd488aa Gerrit-Change-Number: 16258 Gerrit-PatchSet: 12 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Fri, 06 Dec 2019 14:32:27 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
