neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16258 )
Change subject: D-GSM 3/n: implement roaming by mslookup in osmo-hlr ...................................................................... Patch Set 12: (2 comments) https://gerrit.osmocom.org/c/osmo-hlr/+/16258/12/include/osmocom/hlr/proxy.h File include/osmocom/hlr/proxy.h: https://gerrit.osmocom.org/c/osmo-hlr/+/16258/12/include/osmocom/hlr/proxy.h@82 PS12, Line 82: const struct proxy_subscr *proxy_subscr_get_by_imsi(struct proxy *proxy, const char *imsi); My intention was that this API would be easy to move to an SQL db, but this implies a static struct (or at least one that remains valid after the function returns). What was I thinking! https://gerrit.osmocom.org/c/osmo-hlr/+/16258/12/include/osmocom/hlr/proxy.h@87 PS12, Line 87: const struct proxy_subscr *proxy_subscr_get_by_imsi(struct proxy *proxy, const char *imsi); (repeated) -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16258 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I2fe453553c90e6ee527ed13a13089900efd488aa Gerrit-Change-Number: 16258 Gerrit-PatchSet: 12 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-Comment-Date: Tue, 10 Dec 2019 00:48:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
