pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hlr/+/16258 )
Change subject: D-GSM 3/n: implement roaming by mslookup in osmo-hlr ...................................................................... Patch Set 15: (2 comments) https://gerrit.osmocom.org/c/osmo-hlr/+/16258/15/src/mslookup_server_mdns.c File src/mslookup_server_mdns.c: https://gerrit.osmocom.org/c/osmo-hlr/+/16258/15/src/mslookup_server_mdns.c@130 PS15, Line 130: should_run = g_hlr->mslookup.allow_startup This looks like a fix from code belonging to a previous patch? https://gerrit.osmocom.org/c/osmo-hlr/+/16258/15/tests/test_nodes.vty File tests/test_nodes.vty: https://gerrit.osmocom.org/c/osmo-hlr/+/16258/15/tests/test_nodes.vty@403 PS15, Line 403: mdns to 239.192.23.42 4266 This "to" should be removed from VTY too. See for instance above "mdns bind 239.192.23.42 4266". BTW, afaik mDNS uses multicast addresses right? How does that work for source address? Is it the same? one picked by the kernel? May it make sense to have "bind-ip" and "remote-ip" cmds in the client mdns node then? -- To view, visit https://gerrit.osmocom.org/c/osmo-hlr/+/16258 To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hlr Gerrit-Branch: master Gerrit-Change-Id: I2fe453553c90e6ee527ed13a13089900efd488aa Gerrit-Change-Number: 16258 Gerrit-PatchSet: 15 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: neels <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Comment-Date: Wed, 08 Jan 2020 14:44:54 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
